Closed KrisThielemans closed 3 months ago
https://github.com/SyneRBI/SIRF/blob/master/examples/parameter_files/scatter_template.hs does not contain Maximum number of non-arc-corrected bins :=, leading to a default value of 0. This now raises an error due to https://github.com/UCL/STIR/issues/1402, even though the value is set later (as far as I can remember).
Maximum number of non-arc-corrected bins :=
Easiest is to add
Maximum number of non-arc-corrected bins := 63
We can then just as well fix https://github.com/SyneRBI/SIRF/blob/36ed16d21617df8e3276e9890fe46c2b364ab611/examples/Python/PET/scatter_simulation.py#L11-L12 the default is https://github.com/SyneRBI/SIRF/blob/36ed16d21617df8e3276e9890fe46c2b364ab611/examples/Python/PET/scatter_simulation.py#L55
Are we not running these examples in Github Actions?
https://github.com/SyneRBI/SIRF/blob/master/examples/parameter_files/scatter_template.hs does not contain
Maximum number of non-arc-corrected bins :=, leading to a default value of 0. This now raises an error due to https://github.com/UCL/STIR/issues/1402, even though the value is set later (as far as I can remember).Easiest is to add
We can then just as well fix https://github.com/SyneRBI/SIRF/blob/36ed16d21617df8e3276e9890fe46c2b364ab611/examples/Python/PET/scatter_simulation.py#L11-L12 the default is https://github.com/SyneRBI/SIRF/blob/36ed16d21617df8e3276e9890fe46c2b364ab611/examples/Python/PET/scatter_simulation.py#L55
Are we not running these examples in Github Actions?