search

SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
57 stars 29 forks source link

use STIR's sum(), find_max(), operator+= etc #1259

Open KrisThielemans opened 1 month ago

KrisThielemans commented 1 month ago

We currently implement our own max() functions etc. https://github.com/SyneRBI/SIRF/blob/63be16bef56da345407882507e21cfbc1f59f31d/src/xSTIR/cSTIR/stir_data_containers.cpp#L512-L515 However, STIR has equivalents (e.g. find_max() and will soon optimise these. It would therefore be better to call them instead.

This could maybe be done by moving some of the generic implementations to DataContainer, and overriding for the STIR data containers, although that might be more complicated.