search

SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
59 stars 29 forks source link

GitHub Actions fail on MR tests #1267

Closed KrisThielemans closed 3 months ago

KrisThielemans commented 3 months ago

https://github.com/SyneRBI/SIRF/actions/runs/9556091923/job/26340671249#step:9:1053

E               ValueError: cannot fill AcquisitionData of size (np.int32(512), np.int32(8), np.int32(256)) with data of size (1, 1, 8, 131072)

@evgueni-ovtchinnikov this is rather strange, as the recent commit didn't change anything in Gadgetron.

KrisThielemans commented 3 months ago

@evgueni-ovtchinnikov this prevents images being build, so needs urgent attention. sorry

evgueni-ovtchinnikov commented 3 months ago

the failure happens when testing test_imagedata_constructor.py, but SIRF master does not have this script!

apparently, GitHub Actions do some other branch - how can we find which one?

KrisThielemans commented 3 months ago

we have https://github.com/SyneRBI/SIRF/blob/master/.github/workflows/build-test.yml and https://github.com/SyneRBI/SIRF-SuperBuild/blob/master/version_config.cmake of course.

evgueni-ovtchinnikov commented 3 months ago

the failure happens when testing test_imagedata_constructor.py, but SIRF master does not have this script!

found it (scrollbar does not show on VM unless you move the cursor to the window edge), sorry for the false alarm!

on my VM runs ok, so have to debug via GitHub Actions

evgueni-ovtchinnikov commented 3 months ago

looks fixed

likely reason was the change of numpy version, details tomorrow

KrisThielemans commented 3 months ago

ok. Indeed, we're getting numpy 2.0 now. It'd make sense that it's an external change causing this problem now.

evgueni-ovtchinnikov commented 3 months ago

fixed by 8e8d95bfb6423d6a6a794fafe88bca8cda8f4138