search

SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
58 stars 29 forks source link

expose mask functions for PET scatter estimation #1280

Open KrisThielemans opened 1 month ago

KrisThielemans commented 1 month ago

@nicolejurjew, this is now a PR. You can do a PR to my branch to fix/add.

NicoleJurjew commented 1 month ago

Hi Kris,

I got the following error when I tried to build from this branch, with STIR-master: image

I think the problem is that "set_recompute_mask_image" of the stir::ScatterEstimation is not exposed to the sirf::PETScatterEstimator in src/xSTIR/cSTIR/include/sirf/STIR/stir_x.h, as the other newly accessed methods are here:

https://github.com/KrisThielemans/SIRF/blob/51911cc3695f8c9826972e6656fd13b01b5cfaec/src/xSTIR/cSTIR/include/sirf/STIR/stir_x.h#L905C1-L912C10

I think I managed to fix it, PR is here: https://github.com/KrisThielemans/SIRF/pull/2