search

SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
60 stars 29 forks source link

pet_data_path.m et al. need to use a global variable #44

Closed KrisThielemans closed 7 years ago

KrisThielemans commented 7 years ago

pet_data_path checks for SIRF_PET_DATA_PATH but this will never work. If we want this, we would need to add

global SIRF_PET_DATA_PATH

Its documentation will need to mention this global variable.

Same issue for MR of course.

Note that the documentation for pet_data_path currently says it's the MR data path.

evgueni-ovtchinnikov commented 7 years ago

These two scripts (pet_data_path.m and mr_data_path.m) simply allow the user to redefine demos’ input data path by setting a Matlab variable.

An explanation is added to both.

By the way, do we need copyright statements for such small and trivial scripts?

From: Kris Thielemans [mailto:notifications@github.com] Sent: 17 July 2017 01:17 To: CCPPETMR/SIRF Cc: Subscribed Subject: [CCPPETMR/SIRF] pet_data_path.m et al. need to use a global variable (#44)

pet_data_path checks for SIRF_PET_DATA_PATH but this will never work. If we want this, we would need to add

global SIRF_PET_DATA_PATH

Its documentation will need to mention this global variable.

Same issue for MR of course.

Note that the documentation for pet_data_path currently says it's the MR data path.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/CCPPETMR/SIRF/issues/44, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOWfVDFWiXi3S5c2WqBElnKUWPbHXz_Gks5sOqfmgaJpZM4OZdgl.