SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
58 stars 29 forks source link

Expose AXPBY to MATLAB/Python #475

Closed paskino closed 3 years ago

paskino commented 4 years ago

In CIL we are adding a small C library to speed up some calculations.

The first method I expose is a static method to calculate a*X+b*Y, named axpby.

I think it would be useful to have the same method exposed in SIRF with the same signature. In CIL this is by no means finished and could be agreed upon.

paskino commented 4 years ago

The current signature is


def axpby(x,y,out,A,B,dtype=numpy.float32):
    ...

Maybe it'd be better as below?


def axpby(a, x, b, y, out, dtype=numpy.float32):
    ....
paskino commented 4 years ago

For compatibility, I think it'd be better if axpby is not a staticmethod.

KrisThielemans commented 4 years ago

@paskino why is this still open?

evgueni-ovtchinnikov commented 3 years ago

clearly outdated