search

SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
58 stars 29 forks source link

Tag new patch version SIRF 2.2.1? #858

Closed paskino closed 3 years ago

paskino commented 3 years ago

Unittests with CIL will fail because of a bug in SIRF's algebra methods in version 2.2.0.

This is fixed in current master and I would suggest to tag master as 2.2.1 so that builds will be green again.

KrisThielemans commented 3 years ago

We cannot simply tag SIRF to get Travis green. We mostly definitely can't call it a patch release when actually major functionality has been added. And we probably have to tag with a new major version anyway due to incompatibilities, although sadly our https://github.com/SyneRBI/SIRF/blob/master/CHANGES.md isn't very clear about what breaking changes there are, if any at all. Are you, @evgueni-ovtchinnikov or anyone else aware of any? (This should be made very clear of course).

I don't think Travis SIRF is affected.

I believe the way to handle this is to update version_config to set the default SIRF to a "known-good" hash, and then get ready for a proper SIRF release (long overdue).

KrisThielemans commented 3 years ago

So, I don't think this is a SIRF issue, but a SIRF-SuperBuild issue