update_VGA.sh drops into root if no CD present

SyneRBI / SyneRBI_VM

Virtual Machine with pre-installed SyneRBI software

http://www.ccpsynerbi.ac.uk

Apache License 2.0

3 stars 7 forks source link

update_VGA.sh drops into root if no CD present #110

Closed KrisThielemans closed 5 years ago

KrisThielemans commented 5 years ago

quite weird, but if the VGA CD is not "inserted" into the VM. sudo update_VGA.sh says so (as it should) but then display the root prompt. Typing exit makes the script proceeded.

Unexpected behaviour indeed!

KrisThielemans commented 5 years ago

what happens is that VGArun isn't set. Therefore https://github.com/CCPPETMR/CCPPETMR_VM/blob/bda900d9674ff8be05429cf7b41da8491f70c0eb/scripts/update_VGA.sh#L81 just calls sh.

we should have a check a few lines higher like

if [ -z "$VGArun" ]; then
   exit 1
fi