search

SyneRBI / SyneRBI_VM

Virtual Machine with pre-installed SyneRBI software
http://www.ccpsynerbi.ac.uk
Apache License 2.0
3 stars 7 forks source link

option to install prerequisites #159

Closed rijobro closed 4 years ago

rijobro commented 4 years ago

fixes https://github.com/SyneRBI/SyneRBI_VM/issues/156

@johannesmayer did you say you'd be able to try this one?

johannesmayer commented 4 years ago

fixes #156

@johannesmayer did you say you'd be able to try this one?

I checked out this branch, and performed the steps listed in the documentation on the petri-dish example of a v2.1 VM in which I had previously ran the update_VM.sh.

Now I ran the update_VM.sh -s and it had an error saying:

...

fatal: repository 'https://itk.org/ITK.git/' not found
-- Had to git clone more than once:
          3 times.
CMake Error at /home/sirfuser/devel/buildVM/builds/ITK/tmp/ITK-gitclone.cmake:66 (message):
  Failed to clone repository: 'https://itk.org/ITK.git'

CMakeFiles/ITK.dir/build.make:89: recipe for target 'builds/ITK/stamp/ITK-download' failed
make[2]: *** [builds/ITK/stamp/ITK-download] Error 1
CMakeFiles/Makefile2:407: recipe for target 'CMakeFiles/ITK.dir/all' failed
make[1]: *** [CMakeFiles/ITK.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
-- Boost version: 1.65.1
-- Found the following Boost libraries:
....
KrisThielemans commented 4 years ago

interesting. @paskino mentioned something similar. The strange thing is that we've switched ITK_URL to https://github.com/InsightSoftwareConsortium/ITK ~5months ago. are you sure you ran

update_VM -s -t origin/master
rijobro commented 4 years ago

could it be that the URL didn't update if it's cached?

KrisThielemans commented 4 years ago

don't think so. https://github.com/SyneRBI/SyneRBI_VM/blob/80e4ce94e1cad64e72b2cc7f751386321d9ab719/scripts/UPDATE.sh#L174-L176

I suspect that @johannesmayer ran it without the tag, in which case it will resort back to 2.1, which had the out-dated URL presumably,

johannesmayer commented 4 years ago

don't think so. https://github.com/SyneRBI/SyneRBI_VM/blob/80e4ce94e1cad64e72b2cc7f751386321d9ab719/scripts/UPDATE.sh#L174-L176

I suspect that @johannesmayer ran it without the tag, in which case it will resort back to 2.1, which had the out-dated URL presumably,

Yes that's entirely correct, I didn't run it with the tag [it didn't say so in the documentation]. Now I did with it and it worked and performed the update script without any error.

KrisThielemans commented 4 years ago

Excellent. thanks for testing!

@rijobro could you address the doc-related comments? Also, please raise an issue that we can now probably simplify the bootstrap_ubunty.sh script and/or vagrant stuff. But doing that will be for later.

KrisThielemans commented 4 years ago

maybe hang-on withmerging till we understand #160