search

SyneRBI / SyneRBI_VM

Virtual Machine with pre-installed SyneRBI software
http://www.ccpsynerbi.ac.uk
Apache License 2.0
3 stars 7 forks source link

Only SIRF-Exercises requirements.txt is installed #189

Open ashgillman opened 3 years ago

ashgillman commented 3 years ago

On VM I had issues running due to missing dependency deprecation. I don't know if we want to add this to SIRF-Exercises?

Either way, it probably makes sense to also install from SIRF/requrirements.txt

KrisThielemans commented 3 years ago

I don't know if we want to add this to SIRF-Exercises?

not sure what you mean

it probably makes sense to also install from SIRF/requrirements.txt

are you saying as part of the update_VM.sh run SIRF/requrirements.txt? That sounds like a good idea.

ashgillman commented 3 years ago

I don't know if we want to add this to SIRF-Exercises?

not sure what you mean

My thought was that the deprecation is evidently required by the notebooks - since I got an error. So we could explicitly add it to SIRF-Exercises/requirements.txt here. The more I think about it though, we only need it indirectly so I don't think it should be there.

it probably makes sense to also install from SIRF/requrirements.txt

are you saying as part of the update_VM.sh run SIRF/requrirements.txt? That sounds like a good idea.

:+1:

KrisThielemans commented 3 years ago

oh, you mean the deprecation package. yeah, that should be handled via SIRF.