search

SyneRBI / SyneRBI_VM

Virtual Machine with pre-installed SyneRBI software
http://www.ccpsynerbi.ac.uk
Apache License 2.0
3 stars 7 forks source link

Should update_VM.sh run download_data.sh in SIRF-Exercises? #190

Closed ashgillman closed 3 years ago

ashgillman commented 3 years ago

I have no strong opinion here, but we had forgotten and had an error when we ran the exercises. Of course, the error message directly told us to run this script so it is very transparent.

ashgillman commented 3 years ago

It would make this script very slow the first time (although its already not particularly fast)

KrisThielemans commented 3 years ago

I don't think it should. People might want to get the VM for STIR, for CIL, or whatever. Adding a more than 1GB download isn't quite an "update" more an "upgrade". (By the way, arguably our update_VM_to_full_xxx.sh should have been called upgrade_VM... I guess!)

ashgillman commented 3 years ago

Sounds reasonable to me