SyneRBI / SyneRBI_VM

Virtual Machine with pre-installed SyneRBI software
http://www.ccpsynerbi.ac.uk
Apache License 2.0
3 stars 7 forks source link

update from SuperBuild #201

Closed paskino closed 2 years ago

paskino commented 2 years ago

closes #200

paskino commented 2 years ago

I tested this as in https://github.com/SyneRBI/SIRF-SuperBuild/pull/747

KrisThielemans commented 2 years ago

I strongly suggest to port some of this to the SIRf-SuperBuild repo, and in this repo just let UPDATE.sh error out with a message that tells users what to do. (i.e. update their local version of the SB, and execute its UPDATE.sh -s. Otherwise we will have to keep this repo up-to-date for the next one anyway.

However, in the SB, I'd rather keep the original INSTALL* files, and let those call the docker files. Reasons:

paskino commented 2 years ago

Especially the file names in the docker directory aren't very clear!

KrisThielemans commented 2 years ago

Closing here as we won't keep the repo up-to-date. Ideas here are in https://github.com/SyneRBI/SIRF-SuperBuild/pull/755 and https://github.com/SyneRBI/SIRF-SuperBuild/pull/758