search

Syniurge / i2c-amd-mp2

DKMS-ready driver for AMD PCI-E MP2 I2C controllers
22 stars 4 forks source link

changes prototype of amd_mp2_device_match to match kernel 5.3 #14

Closed cmstrickland closed 4 years ago

cmstrickland commented 4 years ago

declaration is different in device.h, and this prevents the build from running because it is treated as a different pointer type

(on my debian laptop running kernel 5.3.0-2-amd64 from linux-image package)

Syniurge commented 4 years ago

Hi, the driver was merged into 5.2 so this DKMS version shouldn't be needed anymore for post-5.2 kernels, only for 5.1 and earlier.

But it seems that the driver isn't being built in Debian kernels: https://packages.debian.org/sid/amd64/linux-image-5.3.0-2-amd64/filelist

So this is a Debian bug and a strange one in my opinion.. shouldn't they always ship with new drivers by default instead of waiting for someone to complain that it's not in the build?

cmstrickland commented 4 years ago

Thanks for the reply. This makes sense. I never really thought about the “why” of this driver, it just worked all the way through 5.2 until yesterday. I have my fix, so my touchpad is useable again in the interim. I will take it to Debian, and see what’s the deal there. Thank you again for your help making my computer work better.

Regards, cms

On 29 Nov 2019, at 22:22, Elie Morisse notifications@github.com wrote:

 Hi, the driver was merged into 5.2 so this DKMS version shouldn't be needed anymore for post-5.2 kernels, only for 5.1 and earlier.

But it seems that the driver isn't being built in Debian kernels: https://packages.debian.org/sid/amd64/linux-image-5.3.0-2-amd64/filelist

So this is a Debian bug and a strange one in my opinion.. shouldn't they always ship with new drivers by default instead of waiting for someone to complain that it's not the build?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.