Can't install "git" package

Stanzilla commented 10 years ago

The error message is not quite clear, it just says "git could not be downloaded"

Diaoul commented 10 years ago

Do you still experience the issue?

aniceberg commented 10 years ago

I can't install any packages- I get "download failed". Is the repo down?

http://packages.synocommunity.com/

Stanzilla commented 10 years ago

@Diaoul yes

aniceberg commented 10 years ago

Is there any place else I can download the SPKs so that I can do a manual install?

Diaoul commented 10 years ago

What architecture are you using?

RedNasSyno commented 10 years ago

Same problems from my side. I have the same problems with downloading the Git, Python, NZBGet packages from SynoCommunity. /var/log/messages reports: PkgSynoMan.cgi: pkgserver.cpp:668 Failed to verify the package

Diaoul commented 10 years ago

What model are you using? Which version of DSM? Please give more information.

shakerben commented 10 years ago

I'm having the same issues on a DS415play running 5.1 -4977

Potentially just a beta issue though.

RedNasSyno commented 10 years ago

I'm using a Synology DS214 with DSM5.1. It worked till 2 days ago. Maybe this has something to do with it:

But that was 2 days ago.

Diaoul commented 10 years ago

Yeah that's my tweet, everything should be ok now.

For DSM 5.1 there is a new "feature" that requires the packages to be signed. I have not implemented this yet so you won't be able to install SynoCommunity's packages with the default DSM settings. You can change the settings in the Package Center setting page I believe.

shakerben commented 10 years ago

I have actually tried that already and had no more luck.

I've been able to install packages from various sources and also manually, just not from the synocommunity source.

Diaoul commented 10 years ago

Maybe that's an issue with the checksum hence the message. Either this is a beta issue or this is an architecture specific issue.

Does the message appear after the actual download? There are two places where there is a checksum, the catalog and the package itself.

I'm away for the weekend so fixes on the repo will come on Sunday evening.

RedNasSyno commented 10 years ago

The same for me. I'm able to install for at least from 3 different sources, but not anymore from synocommunity. The 'signed' package feature doesn't change anything.

RedNasSyno commented 10 years ago

The message appears after the download. So first it says downloading (see the attached picture, sorry for the Dutch) and after downloading it says could not download. scherm1

Stanzilla commented 10 years ago

I am using 5.1 beta but I disabled the signature feature, it's a DS212 MARVELL Kirkwood

aniceberg commented 10 years ago

I am also using the 5.1 beta on a DS411 (88f6282), signature check off.

In the meanwhile, can somebody post the repo download links so that we can manually download and install packages? ddownload-install_fail

shakerben commented 10 years ago

I installed some packages from here - http://synology.w01.eu

Found that in another thread.

When I installed them it said updates were available but trying to update would fail too.

I'd love a link to manually download for the time being.

Diaoul commented 10 years ago

If it doesn't work for DSM 5.1 users I think it's an issue with the beta, ask Synology for support. There are few new features with the repo that might involve checksum verification.

Meanwhile, @piwi82 can you simulate a catalog request and a download in DSM 5.1 with a md5 checksum validation of the package.tgz?

shakerben commented 10 years ago

Thanks Antoine - I'll do a bit more digging and see if I can figure it out.

It only seems to impact this repo though, all others I've tried work ok.

I suppose you have to expect this sort of issue with a beta.

On 31 Oct 2014, at 17:08, Antoine Bertin notifications@github.com wrote:

If it doesn't work for DSM 5.1 users I think it's an issue with the beta, ask Synology for support. There are few new features with the repo that might involve checksum verification.

Meanwhile, @piwi82 can you simulate a catalog request and a download in DSM 5.1 with a md5 checksum validation of the package.tgz?

— Reply to this email directly or view it on GitHub.

Diaoul commented 10 years ago

Others repos may have not implemented the checksum verification. It really depends on the implementation.

Soon I'll publicly release the source code of the repository. In the last weeks I have achieved 100% unittests coverage and that's a big step.

piwi82 commented 10 years ago

@Diaoul : Is checksum validation compared with the md5 stored in INFO file ?

I still use DSM 5.0, so I won't be able to identify what breaks downloads.

There is no big difference between requests in DSM 5.0 and 5.1 except GET/POST method on catalog requests. Here is an example from today logs :

DSM 5.1 catalog request :

user-agent: "synology_88f6282_413j DSM5.1-4977 (package)"
http-request: "GET /?package_update_channel=beta&unique=synology_88f6282_413j&build=4977&language=enu&major=5&arch=88f6282&minor=1&timezone=Eastern&ds_sn=######## HTTP/1.1"

DSM 5.0 catalog request :

user-agent: "synology_88f6282_413j DSM5.0-4528 (package)"
http-request: "POST / HTTP/1.1"
data: "package_update_channel=stable&unique=synology_88f6282_413j&build=4528&language=enu&major=5&arch=88f6282&minor=0&timezone=Brussels&ds_sn=########"

DSM 5.1 download request :

user-agent:"synology_88f6282_413j DSM5.1-4977 (package)"
http-request: "GET /squidguard/1/squidguard_1_88f628x_1594.spk HTTP/1.1"

DSM 5.0 download request :

user-agent:  "synology_88f6282_413j DSM5.0-4528 (package)"
http-request: "GET /btsync/8/btsync_8_88f628x_1594.spk HTTP/1.1"

Diaoul commented 10 years ago

The md5 of the catalog should be compared with the md5sum of the package.tgz in the SPK. It should also be the same that the one in the INFO.

kickserves commented 10 years ago

Have the same issue. On dsm 5.1 on 1812+ and it looks like it is downloading and then says download failed. Same for updates too. And the same occurs for any synocommunity package.

shakerben commented 10 years ago

Thanks for all the hard work Antoine.

Really appreciate it and the quick support with these issues. Look forward to hearing more developments soon.

On 31 Oct 2014, at 18:58, Antoine Bertin notifications@github.com wrote:

Others repos may have not implemented the checksum verification. It really depends on the implementation.

Soon I'll publicly release the source code of the repository. In the last weeks I have achieved 100% unittests coverage and that's a big step.

— Reply to this email directly or view it on GitHub.

andreground commented 10 years ago

Same here https://github.com/SynoCommunity/spksrc/issues/1298

kickserves commented 10 years ago

This are the entries from /var/log/messages when attempting to download packages from synocommunity. None of them work on DSM 5.1 regardless of whatever settings changes you make on the server.

Oct 31 10:00:54 xxxx PkgSynoMan.cgi: pkgserver.cpp:668 Failed to verify the package /volume1/@tmp/@synopkg/@download/git/@SYNOPKG_DOWNLOAD_git by MD5 bb3deed6c5846c13c10ed16fe48bce0d

Oct 31 13:50:57 xxxx PkgSynoMan.cgi: pkgserver.cpp:668 Failed to verify the package /volume1/@tmp/@synopkg/@download/nzbget-testing/@SYNOPKG_DOWNLOAD_nzbget-testing by MD5 a660840b8fabae4c9cfe5a1d2f4edd19

Oct 31 13:51:08 xxxx PkgSynoMan.cgi: pkgserver.cpp:668 Failed to verify the package /volume1/@tmp/@synopkg/@download/nzbget/@SYNOPKG_DOWNLOAD_nzbget by MD5 5027b29878e382166cd66cb4d44db77c

hansolor commented 10 years ago

same here i'am on a hold whit 5.1

andreground commented 10 years ago

That's what happens on my ds212j when trying to install a package:

Nov 2 11:57:32 DiskStation PkgSynoMan.cgi: pkgserver.cpp:668 Failed to verify the package /volume1/@tmp/@synopkg/@download/btsync/@SYNOPKG_DOWNLOAD_btsync by MD5 d880cd926fe2808a18b8e0817d11d6a8

Signature validation is OFF

Diaoul commented 10 years ago

I have identified the issue. It's because the md5 sent by the catalog is the md5sum of the package.tgz inside the SPK but it should be the md5sum of the whole SPK. Hence the failed verification.

I'll fix this ASAP.

shakerben commented 10 years ago

Thanks Antoine. Look forward to the fix!

On 2 Nov 2014, at 20:41, Antoine Bertin notifications@github.com wrote:

I have identified the issue. It's because the md5 sent by the catalog is the md5sum of the package.tgz inside the SPK but it should be the md5sum of the whole SPK. Hence the failed verification.

I'll fix this ASAP.

— Reply to this email directly or view it on GitHub.

andreground commented 10 years ago

Super top! Thanks!

Il domenica 2 novembre 2014, Antoine Bertin notifications@github.com ha scritto:

I have identified the issue. It's because the md5 sent by the catalog is the md5sum of the package.tgz inside the SPK but it should be the md5sum of the whole SPK. Hence the failed verification.

I'll fix this ASAP.

— Reply to this email directly or view it on GitHub https://github.com/SynoCommunity/spksrc/issues/1296#issuecomment-61422640 .

Diaoul commented 10 years ago

Can you confirm this is fixed?

hansolor commented 10 years ago

Thanks you it is working again

shakerben commented 10 years ago

Yep works for me now too.

Thank you!

kickserves commented 10 years ago

Works now. Thank you.

RedNasSyno commented 10 years ago

Thanks Antoine for the good work! It's working again.

SynoCommunity / spksrc

Can't install "git" package #1296