search

SynoCommunity / spksrc

Cross compilation framework to create native packages for the Synology's NAS
https://synocommunity.com
Other
3.03k stars 1.23k forks source link

[Request] Add ZNC Playback Module #1457

Closed Pretz closed 9 years ago

Pretz commented 9 years ago

https://github.com/jpnurmi/znc-playback (http://wiki.znc.in/Playback)

This allows more sophisticated buffer playback for clients such as Textual and Mobile Colloquy

Alternatively, I would be happy to build it myself if znc-buildmod were included so modules could be manually added.

Thanks for the ZNC package!

Dr-Bean commented 9 years ago

I don't think that we can include znc-buildmod in the package...but adding the module is possible.

Dr-Bean commented 9 years ago

Right...while I say we can add the module, there's a snag. According to the Playback wiki page: 

This external module is a work in progress.
Please note that it requires the latest development version of ZNC.

We're using the latest stable of ZNC (1.4), and we'd need 1.6.0-beta1 for this. Tested with 1.4 before I noticed: no go. I'd prefer to wait until a new stable version of ZNC is released. @Diaoul, your opinion?

Diaoul commented 9 years ago

We'll wait for a new stable release of ZNC.

Dr-Bean commented 9 years ago

Adding an upstream tag to this then. @Pretz, maybe you can keep an eye out for an updated version of ZNC too? Then we're less likely to miss it ;)

Pretz commented 9 years ago

@Dr-Bean absolutely, thanks for the positive response! I completely understand waiting for upstream, I didn't realize that znc-playback depended on dev znc when I made the request.

dgw commented 9 years ago

ZNC 1.6.0 is released as stable since mid-February.

iruyanka commented 9 years ago

Dr-Bean Please test add Push module on ZNC 1.6.

https://github.com/SynoCommunity/spksrc/issues/1521

http://wiki.znc.in/Push

Official project page: https://github.com/jreese/znc-push

ZNC Push is a module for ZNC that will send notifications to multiple push notification services, or SMS for any private message or channel highlight that matches a configurable set of conditions. ZNC Push supports multiple push services, including Boxcar, Pushover, and PushBullet.

You can get this module's source code and documentation at the github project page. You should also read compiling modules.

Thanks for the ZNC package!

Dr-Bean commented 9 years ago

Updated ZNC to 1.6.0 and added the module with 831a7b18fc0f15370d6ebeb4527a18edfd20594c. The packages will be released on the beta channel Note: packages not available yet, I'll report here when they are. Probably later this week

Dr-Bean commented 9 years ago

Well, that's just great :/ ZNC 1.6 was rewritten to use C++11. From what I'm seeing, currently only four of our toolchains support that: x86_64, DSM5.1. Maybe the 5.2 toolchains will help, haven't tested.

Diaoul commented 9 years ago

I believe there is a flag to enable C++11 support in GCC but that seems to be limited to recent GCC only...

Edit: that's -std=c++11

Dr-Bean commented 9 years ago

GCC4.7+ apparently. Most of our toolchains, except the x86_64 ones, are based on GCC 4.6.4 (edit: and older) Same for DSM5.2 beta toolchains, so using those won't help either.

Diaoul commented 9 years ago

I sent an email to Synology, but I doubt that'll be ready for 5.2.

Diaoul commented 9 years ago

C++11 is quite new, I don't know the reason ZNC had to make the switch but if possible we should ask upstream to revert this change.

cytec commented 9 years ago

Well i think that depends on the point of view... C++11 is from 2011 so that are ~4 years which is a not so new in my opinion and especially in internet time... but i found that there is a major lack of support in some toolchains :(

Diaoul commented 9 years ago

Debian stable still uses 4.6: https://packages.debian.org/wheezy/gcc

Dr-Bean commented 9 years ago

With 1.6, ZNC has made quite some changes to their code based on the new standard (I was briefly considering patching things back myself until I saw that. Nope...), so I don't think that's a viable option.

Besides, seems to me the issue isn't the standard itself, but the fact we're stuck on such old GCC versions. 4.8/4.9 are current, right? (edit: and Debian Jessie would be 4.9, if I'm reading it right?) Edit: well, I say 'old'...not that old after all. 4.6.4 seems to be released just over a year and a half ago.

What about PR #664? Might be an alternative way of looking at it, although it might need some work...

Dr-Bean commented 9 years ago

ZNC 1.6 for x86-64 arches has been published as a beta package. ZNC 1.4 is still available on stable for that arch and others that cannot be updated due to GCC being too old.

If Synology updates the toolchains to GCC4.7 with the next update, we can revisit this for the other arches.