SynoCommunity / spksrc

Cross compilation framework to create native packages for the Synology's NAS
https://synocommunity.com
Other
3.03k stars 1.23k forks source link

Please update NZBGet to 17.0 #2420

Closed joeyd2 closed 7 years ago

joeyd2 commented 8 years ago

Please update NZBGet to 17.0

rvdlaar commented 8 years ago

What he said

1shez commented 8 years ago

What he said

benjmd commented 8 years ago

What he said

KaraokeStu commented 8 years ago

Updated as per request, pull request pending

rvdlaar commented 8 years ago

Awesome. Thanks.

KaraokeStu commented 8 years ago

No problem

KaraokeStu commented 8 years ago

I have closed the pull request due to problems with requiring GCC 4.9 or 5.0

KaraokeStu commented 8 years ago

Please close this issue - it is a duplicate of https://github.com/SynoCommunity/spksrc/issues/2185

joeyd2 commented 8 years ago

So it isn't getting updated? :(

KaraokeStu commented 8 years ago

It will be supported, but only from DSM 6.x - unless someone knows how to compile GCC 4.9 for DSM 5.x. And DSM 6.x still has its own set of issues working with custom packages

Thaek commented 8 years ago

Any news on this? :-) NZBGet 17 was released almost two weeks now and there is a feature that I requested that was implemented in 17, would be very nice if I could test it.

So if I have DSM 6.x can I expect this to be updated? If this is not getting updated because it would break nzbget for DSM 5.x, can't you introduce it as a new package?

Thaek commented 8 years ago

Someone backported NZBGET 17 to work with C++ 11, maybe this will help you for DSM 5.x? http://nuxref.com/2016/08/03/nzbget-v17-centos-7/

cytec commented 8 years ago

seems like that got already merged (see https://github.com/nzbget/nzbget/pull/256) and is flagged for 17.1 so let's wait for 17.1 to be released (and hopfeully compile for DSM 5x)

Thaek commented 8 years ago

Wait for 17.1? ;-/ ugg that could take ages, it's not like they create releases every month. :-(

KaraokeStu commented 8 years ago

Feel free to amend the package yourself and create the relevant patch for it, however I don't think it would be worth the double effort of us doing that, then undoing it once 17.1 is released.

I wouldn't think it'll be too long for 17.1, given that it will be likely a fair few bugs will have crept into the new codebase

schumi2004 commented 8 years ago

Another duplicate https://github.com/SynoCommunity/spksrc/issues/2185

Anyway, i compiled 17.1 with DMS6 toolchain but it keeps complaining about: configure: error: "ncurses library not found"

I already added cross/ncurses to depends in spk makefile but it doesn't make a difference.

Any ideas?

/edit: c++14 doesn't seem to be a issue now: checking whether /home/openelec/github/spksrc/toolchains/syno-alpine-6.0/work/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-g++ supports C++14 features by default... no checking whether /home/openelec/github/spksrc/toolchains/syno-alpine-6.0/work/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-g++ supports C++14 features with -std=c++14... yes checking how to run the C++ preprocessor... /home/openelec/github/spksrc/toolchains/syno-alpine-6.0/work/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-g++ -E

cytec commented 8 years ago

@schumi2004 have you tried ncursesw?

schumi2004 commented 8 years ago

@cytec doesn't seem to make any difference.

cytec commented 8 years ago

@schumi2004 strange... what about --with-libcurses-includes and/or --with-libcurses-libraries and provide the path to include/lib where curses is located?

schumi2004 commented 8 years ago

I'm not a programmer so i'm not 100% sure where to place these options. Should that be something like this? CONFIGURE_ARGS = --with-libcurses-includes=$(WORK_DIR)/../../../ncurses-6.0/lib

cytec commented 8 years ago

something like this should work i think:

CONFIGURE_ARGS = --with-libcurses-includes="$(WORK_DIR)/install$(INSTALL_PREFIX)/include" --with-libcurses-libraries="$(WORK_DIR)/install$(INSTALL_PREFIX)/lib"

schumi2004 commented 8 years ago

Thank you very much, that worked ;) I don't think it's usefull to submit a PR for this since there is something about DSM6 toolchains right?

/home/openelec/github/spksrc/spk/nzbget-testing/../../packages/nzbget-testing_alpine-6.0_17.1~testing-12.spk --group=root --owner=root package.tgz INFO PACKAGE_ICON.PNG PACKAGE_ICON_120.PNG scripts WIZARD_UIFILES) make[1]: Leaving directory '/home/openelec/github/spksrc/spk/nzbget-testing' 03:28:49 {nzbget} ~/github/spksrc/spk/nzbget-testing$

cytec commented 8 years ago

well... personally i think you can go ahead and create a PR if you got it working... afaik the DSM 6 problem still isn't solved and will require some work on more package... so no need to wait for the DSM fix before opening a PR

schumi2004 commented 8 years ago

I'll see what i can do. This also means i need to add all DMS6 toolchains available. I think i'll split them in 2 separate PR's.

Thanks again for helping out ;)

cytec commented 8 years ago

ah... you're talking about 17.1 with DSM 6 Toolchains? thought you where compiling with 5.x ... forget what i said then :D

Thaek commented 8 years ago

NZBGET 17.1 was released two days ago which allows to compile with GCC 4.8 with the following configure command: CXXFLAGS="-std=c++11 -O2 -s" ./configure --disable-cpp-check

Can someone compile and update Synocommunity to 17.1?

KaraokeStu commented 8 years ago

I'll have a quick look and see if I can get it to compile, however I'll need to check to see if I can make it work for 5.x too, as otherwise I'll need to specify a minimum DSM version and it might be best to create a new package for 6.x - what do you think @cytec and @Dr-Bean ?

KaraokeStu commented 8 years ago

I've tested and this still does not compile using the 5.x toochains, so still can't be done within the framework as it stands until we at least have 6.x toolchains

hugbug commented 8 years ago

For all waiting - a reminder that nzbget can be installed on most devices via official installer package as documented in NZBGet - Installation on Linux.

One thing you would need to figure out on your own is how to make it start automatically on boot.

Ashkaan commented 8 years ago

For all waiting - a reminder that nzbget can be installed on most devices via official installer package as documented in NZBGet - Installation on Linux.

Yes, but an spk would be so much nicer because it will include the boot stuff too.

Thaek commented 8 years ago

Still waiting here. Guess I will have to go with the manual installation of the binaries and stop using synocommunity - thanks anyway was nice while it lasted.

Ashkaan commented 8 years ago

No, don't give up! There must be someone still interested in working on this!

It sounds like there's an issue supporting old version of DSM. Can you guys make one that works on 6+?

doppelhelix23 commented 8 years ago

any news on that package?

schumi2004 commented 8 years ago

I will post a link tomorrow of packages that succeeded compiling against dsm6 tool chain. A few failed but didn't checked why they failed.

KaraokeStu commented 8 years ago

Thanks for the effort @schumi2004

schumi2004 commented 8 years ago

Thanks for the reminder, totally forgot to upload files. Compiling latest git version now, 18.0 if i'm correct, will place them in same folder. Will also check what happened with other architectures on why they failed. https://www.dropbox.com/sh/0vu56iaifllqoga/AAB9zZfCUDwIXX9rB3cBaGgXa?dl=0

Ashkaan commented 8 years ago

Thank you, @schumi2004

I can't get it to run on my Avaton system (DS1815+). I've tried 18 and 17.1. Anyone else having issues?

schumi2004 commented 8 years ago

Do you get any error or it just wont start via package manager? Could you try to launch it manually? /var/packages/nzbget-testing/scripts/start-stop-status start

Ashkaan commented 8 years ago

It loads like it's going to run (no error) and then just simply never starts.

I tried launching manually and it has no output. It looks like it thinks it started, but it never actually starts.

schumi2004 commented 8 years ago

That's strange, I'm running the same version on a DS715. It's not running twice? ps aux | grep nzbget

Ashkaan commented 8 years ago

OMG.. I had poor permissions. So sorry! This works GREAT!!

Any chance of compiling the latest stable?

schumi2004 commented 8 years ago

Will upload stable version later today.

TomVanHaver commented 8 years ago

@schumi2004 Hi, Since i heard that unpacking recent packages is incompatible with my current nzb version (16.4 on dsm 6+) i am interested in updating nzbget.

Can i download/install the .spk on the dropbox link above (or somewhere else?) If not, are there any instructions on how to create such a .spk package ?

Thank you, Tom.

schumi2004 commented 8 years ago

You can download from DB link above, there aren't any official packages that I'm aware of. I would suggest to pick 17.1 stable. Not all architectures are there yet, didn't looked at others why they failed compiling.

TomVanHaver commented 8 years ago

I have an ds214+ with an Marvell Armada XP cpu, so i guess i need the armada package, correct ? If this does not work as expected, can i just install the community package again ?

Is an official 17.x release imminent ?

schumi2004 commented 8 years ago

I think your out of luck since armadaxp failed to compile (it's not on my DB) Will check tomorow what is wrong with armadaxp. 17.1 is official yes http://nzbget.net/download/ I updated version number also so you can't downgrade, you then need to remove and re-install it. Make backups before you proceed then you can easily go back.

@TomVanHaver It's compiling now. For some reason the armadaxp toolchain dir changed from marvell to unknown. I think it should work but only you can test. It's uploaded to DB.

TomVanHaver commented 8 years ago

@schumi2004 Thank you very much for the effort.

Please do not be offended, but i do not know/trust you enough to install the .spk you have build. What is your relation to the nzb project ? Is it necessary to install the 17.1 update in order to download/process the "latest finds"? If so, do you have an idea when the official release will be? Or can you point me to a guide to build a version for myself ?

Again thank you very much for your help in advance.

schumi2004 commented 8 years ago

I understand the trust thing. I have no relation to SynoCommunity or nzbget besides getting things to work for my own situation, improve or find bugs and when I can submit things to help community. You can drop me an email (my nick @gmail) and I'll send you my source or wait until I have uploaded it on my github and you can validate code and compile it yourself ;)

Limb commented 7 years ago

@schumi2004 Can you post the changes you made to compile 17.1 to github?

schumi2004 commented 7 years ago

Pushed it to my github (nzbget branch), to lazy to squash commits though.