SynoCommunity / spksrc

Cross compilation framework to create native packages for the Synology's NAS
https://synocommunity.com
Other
3.04k stars 1.24k forks source link

Redis 4.0 #3469

Closed flip111 closed 6 years ago

flip111 commented 6 years ago

Redis from SynoCommunity is on version 3.0.5-5

Redis 4.0:

Redis 4.0 was released as GA in July 2017. Contains several big improvements: a modules system, much better replication (PSYNC2), improvements to eviction policies, threaded DEL/FLUSH, mixed RDB+AOF format, Raspberry Pi support as primary platform, the new MEMORY command, Redis Cluster support for Nat/Docker, active memory defragmentation, memory usage and performance improvements, much faster Redis Cluster key creation, many other smaller features and a number of behavior fixed.

I think 1 year is enough to mature version 4.0 (which is now 4.0.11), work on redis 5.0 is already underway.

I don't understand "Bleeding Edge" advertisement on https://synocommunity.com/ bleeding edge is 5.0 or last commit on master repository.

BenjV commented 6 years ago

I don't understand people having an attitude about things they get for free which are provided by people who do the work in their free time for no payment at all.

By the way Redis is a hardly downloaded package, so the urgency is low to adapt it.

flip111 commented 6 years ago

I'm just saying that "bleeding edge" sets expectations which are not true for this package. It's not my fault that i have this expectation as it says so on the front page. If you want me or any other users not to expect packages to be up to date that don't put it on the front page. Simple.

I read the FAQ and afaik i can make this package request (update). I'm not even addressing any particular people, the ones you refer to as "people who do the work in their free time for no payment at all". It's common on github to say "Pull Request are welcome" (meaning: do it yourself). Since Redis 4.0 package is not there yet, it's not provided. I'm sure the Redis 3.0 package is tip top.

BenjV commented 6 years ago

It is difficult to be polite in this days of (un)social media.

If you complain about a statement on the website of the SynoCommunity then that is a reflection on those people, because they are the one who put it there. Complaining is never a good way to get things done for free.

And unless Redis 4.0 is not backwards compatible with Redis 3.0 it will be no problem to do a pull request for Redis 3.0 and upgrade it to Redis 4.0. If it is not compatible you can also create a new package for Redis 4.0

In other words "do it yourself" or ask polite.

Diaoul commented 6 years ago

There is no need for harsh words. SynoCommunity is as the name suggests, community-based, most popular packages are frequently updated thanks to involved members (sometimes also users) of the said packages. Keeping track of all upstream changes is a heavy task that is not currently done by maintainers and never will. If you have a package update request, it will not be rejected for backward compatibility reasons. In that regard, the statement is correct. Backward compatibility is always sought but it must not be a reason for holding a package release forever.

You can ask for a package update politely as someone will work on it for free, submit a Pull Request or just don't use SynoCommunity if you're not happy with it and don't want to contribute.

flip111 commented 6 years ago

Maybe you guys would be happy if i dropped in "please" and "with sugar on top" in a few places. That would have been nice for sure. However i didn't call out to any people and the things i said are factually true. To say:

is too much!! Because what i've written may not be nice, but it's not these accusations either. I feel all this stems from my comment about "bleeding edge" which is (like i said before) not my fault that i have this expectation. Maybe you can start with this "politeness" yourself and set a good example for people new to the community. Now i don't feel welcome anymore.