search

SynoCommunity / spksrc

Cross compilation framework to create native packages for the Synology's NAS
https://synocommunity.com
Other
3.02k stars 1.23k forks source link

Port fdupes to ARM platforms (armada38x) #3525

Closed obourdon closed 5 years ago

obourdon commented 5 years ago

Setup

Package Name: fdupes Package Version:

NAS Model: DS218j NAS Architecture: armada38x DSM version: 6.1/6.2

Expected behavior

fdupes package should compile

Actual behavior

error when compiling fdupes

Steps to reproduce

1. use docker dev env 2. cd spk/fdupes && make arch-armanda38x

Other logs

E.g. command output

/spksrc/toolchains/syno-armada38x-6.1/work/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sysroot/usr/include/gnu/stubs.h:7:29: fatal error: gnu/stubs-soft.h: No such file or directory
 # include <gnu/stubs-soft.h>
                             ^
compilation terminated.
ymartin59 commented 5 years ago

There is no missing file in armada38x toolchain. fdupes is a old beta package that has never been ported to ARM platforms: https://synocommunity.com/package/fdupes Reference: https://stackoverflow.com/questions/49139125/fatal-error-gnu-stubs-soft-h-no-such-file-or-directory

obourdon commented 5 years ago

@ymartin59 even if I agree concerning fdupes being "old"/non-ported I still disagree on the fact that I do think there is a missing file or a bug in the toolchain contents.

Taking this out of fdupes context if the file /spksrc/toolchains/syno-armada38x-6.1/work/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sysroot/usr/include/gnu/stubs.h reference both stubs-hard.h which exists and stubs-soft.h which does not (depending on the compilation flag of course), this is definitely an issue from my perspective

ymartin59 commented 5 years ago

I guess you have done an effort to "look at" (I do not dare to say "read") StackOverflow reference... gcc is invoked with improper arguments for ARM target. Not a problem of toolchain but fdupes make statements. Period.

BenjV commented 5 years ago

I agree

obourdon commented 5 years ago

@ymartin59 yes I did read it and think I understood its contents but as stated in my previous comment it is not because adding compilation flag(s) makes the issue go away means that there is nothing wrong in all the other cases. Furthermore comparing this toolchain with the others (some also ARM based) where the issue is not present tends to confirm this. But may be I am way too biased due to my past experiences ;-)

ymartin59 commented 5 years ago

OK why not, but that is not the right place to complain about it. Toolchains are provided by Synology (I guess only repack gcc provided by suppliers like Marvell)... So post on their forum https://forum.synology.com/ and/or open a support request...

obourdon commented 5 years ago

Done https://community.synology.com/forum/14/post/121082