SynoCommunity / spksrc

Cross compilation framework to create native packages for the Synology's NAS
https://synocommunity.com
Other
3.04k stars 1.23k forks source link

Allow volume path with mixed case (Volume1 for example) #3974

Closed odingalt closed 4 years ago

odingalt commented 4 years ago

For new Package Requests, see the guidelines

Setup

Package Name: NZBGet from Diaoul that uses this source Package Version: 16.4-22

NAS Model: NAS Architecture: DSM version:

Expected behavior

My synology got a volume name of /Volume1/ which disallows all packages using this packager. Synology does not allow volume name changes without destructing the underlying functionality of the whole NAS. Feature request to allow mixed case volume names.

Actual behavior

Tell us what happens instead

Steps to reproduce

1. 2. 3.

Package log

Check Package Center or /usr/local/{package}/var/

Insert the package log here

Other logs

E.g. /var/log/messages or /var/log/synopkg.log

Insert log here
hgy59 commented 4 years ago

Can anyone else confirm that it is possible to have volumes with uppercase 'V'? This is relativly easy to fix. It is just a validation in the wizard files. I assume only the first letter might be uppercase?

odingalt commented 4 years ago

I would withdraw this perhaps. I recently found my NAS is configured as such and certainly due to confusion on my part:

/volume1/Volume1/Downloads

hgy59 commented 4 years ago

@odingalt minio is the first published package with this fix. May be you want to try it before the package server is offline for about one week.

odingalt commented 4 years ago

My mistake folks. I can't confirm that uppercase is allowed. I managed to confuse myself as my NAS for a long time has had volume1 with all items in folder Volume1.