search

SynologyOpenSource / synology-csi

Apache License 2.0
499 stars 107 forks source link

Lable for iscsi volumes #39

Open jhueppauff opened 2 years ago

jhueppauff commented 2 years ago

Hi,

it would be great to have an identifiable name for SAN/ISCI volumes. Id works, but if a pvc was deleted it is hard to know which volume can be deleted safely. I know it is shown as ready instead of connected. But it would be great to have some way to know what volume is used for what without relying on kubernetes

matfiz commented 1 year ago

I totally agree, even a namespace label would be extremely helpful

Twanislas commented 1 year ago

Hi,

I submitted https://github.com/democratic-csi/democratic-csi/issues/282 for them to support exactly that, you might want to give it a try too as synology-csi is not compatible with Talos nodes out of the box.

Cheers !

vaskozl commented 1 year ago

With https://kubernetes-csi.github.io/docs/external-provisioner.html#persistentvolumeclaim-and-persistentvolume-parameter we can get the name/namespace sent to the controller and add it to the dsm api call as a description or even directly in the name.

Should be fairly easy to add.

vaskozl commented 1 year ago

https://github.com/SynologyOpenSource/synology-csi/issues/21 is similar (desc instead of name).