search

SynologyOpenSource / synology-csi

Apache License 2.0
499 stars 107 forks source link

Set node.startup to manual for iSCSI targets at login #55

Closed kincl closed 1 year ago

kincl commented 1 year ago

Fixes a condition where the default node.startup is automatic and a node reboots, iscsid will attempt to create sessions for all of the targets after the reboot. This causes issues when the target needs to move to another host in the cluster.

Instead, for Synology-CSI controlled volumes we want the CSI to control the lifecycle of a session.

Fixes: #32

k/k had a similar fix for the in-tree iscsi driver: https://github.com/kubernetes/kubernetes/pull/57475

kincl commented 1 year ago

There are two commits, one for the change and the second for the formatting changes recommended by go fmt