search

SynologyOpenSource / synology-csi

Apache License 2.0
529 stars 115 forks source link

Add login retry for session timeout #56

Closed kincl closed 1 year ago

kincl commented 1 year ago

Error code 106 is a session timeout error so we should retry login before erroring out on the request

The other changes are just gofmt updates

kincl commented 1 year ago

I was seeing this error in my logs and I think it is related to issues with the iSCSI session not being correctly logged out on pod delete.

2023-07-15T13:09:38Z [INFO] [driver/utils.go:104] GRPC call: /csi.v1.Node/NodeUnstageVolume
2023-07-15T13:09:38Z [INFO] [driver/utils.go:105] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/csi.san.synology.com/4f5270dfe2ddf82104753083a8665ac488712bda135ad587d0a57c21220997a8/globalmount","volume
_id":"4a51782e-5ae3-4ef8-977c-ef1181913fe6"}
2023-07-15T13:09:38Z [ERROR] [service/dsm.go:537] [192.168.5.15] Failed to list targets: DSM Api error. Error code:106
2023-07-15T13:09:39Z [INFO] [webapi/dsmwebapi.go:52] Re-login succeeded.
2023-07-15T13:09:39Z [INFO] [driver/utils.go:110] GRPC response: {}
kincl commented 1 year ago

This also fixes #32 for me