search

SynologyOpenSource / synology-csi

Apache License 2.0
529 stars 115 forks source link

k8s version check: --short not longer supported #61

Closed ppuschmann closed 3 months ago

ppuschmann commented 1 year ago

Apparently newer versions of kubectl do not longer support the argument --short for the version check.

Output:

$ ./scripts/deploy.sh install --basic
==== Creates namespace and secrets, then installs synology-csi ====
error: unknown flag: --short
See 'kubectl version --help' for usage.
Version not supported:

Possible fix: Remove the argument --short from https://github.com/SynologyOpenSource/synology-csi/blob/main/scripts/deploy.sh#L13

Example output from kubectl:

$ kubectl version
Client Version: v1.28.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.4+k3s1

This should be fine.

chihyuwu commented 3 months ago

Fixed in commit 6c990fc9541572c23e31312b63b5bec452ca49e0. Closing this issue.