pk: ECDHBase generate public key from private key

Synss / python-mbedtls

Cryptographic library with an mbed TLS back end

MIT License

79 stars 28 forks source link

pk: ECDHBase generate public key from private key #22

Closed stepheny closed 5 years ago

stepheny commented 5 years ago

The PR fulfills these requirements

[x] This change is a single feature in a single commit.
[x] The commit message follows our commit guidelines.
[x] The code formatting follows our coding guidelines.
[x] Tests have been added for the changes.
[ ] Docs have been added / updated (docstrings and README).
[ ] A one-liner has been added to the ChangeLog (for new features).

More details in CONTRIBUTING.

I am submitting a …

[ ] Bug fix
[x] New feature
[ ] Tests update (new test vector, etc.)
[ ] Docs update
[ ] Other (please complete)

Description

Allow ECDHBase generate public key from loaded private key.

Other information

stepheny commented 5 years ago

Similar to above, these methods directly manipulates c struct members. I hesitates to claim them as public in python since they bypassed mbedtls api abstraction. I think you are the one to decide whether this should be public, and I agree in advance.

Synss commented 5 years ago

Similar to above, these methods directly manipulates c struct members. I hesitates to claim them as public in python since they bypassed mbedtls api abstraction. I think you are the one to decide whether this should be public, and I agree in advance.

OK, I will think about it some more then. Although, mbedtls typically provides setters but no getters. For getters, it is fine to get the stuff from the structs, I think. But I will look into this some more and maybe I'll make the change myself later.

Synss commented 5 years ago

Oh, I see that you have made the changes. In the future, please do not force push in the PR. It makes it more difficult to follow. I can always squash the changes before merging. I will still check why the tests have failed before merging.