search

Syntaf / travis-sphinx

A standalone script for automated building and deploying of sphinx docs via travis-ci
GNU General Public License v3.0
113 stars 20 forks source link

Commands refactoring. #23

Closed lmignon closed 6 years ago

lmignon commented 6 years ago

The primary goal of this PR is to allow to write a CNAME file into the generated documentation. In the same time, I've refactored the code to take benefit of the 'click' library and depend of the ghp-import library library in place of a clone of its repository.

Syntaf commented 6 years ago

Thanks for your work on this Imignon, i'll check out the code later tonight and see if everything looks good to merge

lmignon commented 6 years ago

@Syntaf travis is red since it seems that the GH_TOKEN is missing.

Syntaf commented 6 years ago

Tested and LGTM, going to go ahead and merge. Are you interested in being added as maintainer considering this is such a sizable code change?

Syntaf commented 6 years ago

Side note, I assumed this was typo so I fixed it:

you had travis-sphinx build --source=other/dir/doc build in the README.md, which I changed to travis-sphinx build --source=other/dir/doc

lmignon commented 6 years ago

@syntaf Indeed it's a typo :smile: I'll be happy to be a maintainer of this lib. Thank you for ypu trust