Closed berquist closed 6 years ago
Merging #43 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 5 5
Lines 138 138
=======================================
Hits 113 113
Misses 25 25
Impacted Files | Coverage Δ | |
---|---|---|
travis_sphinx/build.py | 83.33% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1082606...0c12039. Read the comment docs.
Thanks for the PR and sorry for the delay. I'll take a look at this when I'm home from work today
Is the actual default sourcedir for sphinx doc? Or is this a change made on personal opinion about the naming of mose sourcedirs?
Regardless, this introduces a breaking change into travis-sphinx, something I'm not willing to do. Existing repositories using the default doc
dir would start failing after this. Having packages randomly start breaking on me is aggravating to say the least, and I don't want to be one of those packages.
I appreciate the PR however, thank you for taking the time to look into this!
Is the actual default sourcedir for sphinx doc? Or is this a change made on personal opinion about the naming of mose sourcedirs?
There is no default, since sphinx-quickstart
places everything in your current working directory. I proposed the change because I was confused about how the language in the README switches between the two, and why doc
and docs
were appearing in my source tree, and I needed to read all the source code to understand what the default directories are.
The default top-level for building is
doc
, and most documentation refers todoc
rather thandocs
. Switch everything todoc
.