search

SyntaxUI / syntaxui

Get free access to pre-built, Tailwind CSS-powered components, animations and effects - brought to life using Framer Motion. Just copy, paste and you're ready to go!
https://syntaxui.com
MIT License
587 stars 43 forks source link

[Enhance]:Changed 'a' tag to 'Link' tag #189

Closed vanshavenger closed 1 month ago

vanshavenger commented 1 month ago

In this PR, i have changed all the 'a' tags with 'Link' tags as they are more optimise in case of NextJs

also set target ='_blank' in the footer component to follow the same behavior as other social links to open them in external tab.

vercel[bot] commented 1 month ago

@vanshavenger is attempting to deploy a commit to the SyntaxUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 2:58pm
shrix1 commented 1 month ago

Sometimes, randomly this tag might cause 404 issue (super random), Its happened 3 times for me

vanshavenger commented 1 month ago

Sometimes, randomly this tag might cause 404 issue (super random), Its happened 3 times for me

In Production build the Link tags are generally converted to a tags only

Ansub commented 1 month ago

Revert back to a tag for the hover spring component as the code here will be used by people using different tech stacks

Please do it for rest of the components which are in showcase folder

vanshavenger commented 1 month ago

@Ansub any other changes that are required? also got your pov why these changes were important 👍

Ansub commented 1 month ago

Congratulations! message on SyntaxUI discord to get contributor badge :)