Fixed `Get Portfolio Template` button

[epoll31]

Description

I fixed the homepage button that says 'Get Portfolio Template'

Proposed Changes

• Renamed DiscordButton to TemplatesButton
• Removed the useRouter navigation onClick in favor of a normal Link with a passHref to a motion.a
• Changed the href to /templates because the original pr removed the /templates/minimal-portfolio path

Checklist

Please check the boxes that apply:

• [x] I have rebased my branch on top of the latest main branch.
• [x] I have tested the changes locally
• [x] I ran npm run build and build is successful
• [x] I have added necessary documentation (if applicable)
• [x] I have updated the credits.md file (if applicable)

[vercel[bot]]

@epoll31 is attempting to deploy a commit to the SyntaxUI Team on Vercel.

A member of the Team first needs to authorize it.

[Ansub]

useRouter() is better in this case as it doesn't performs page-reload when doing client-side transitions

you can read more here: https://blog.logrocket.com/next-js-routechangestart-router-events/

[epoll31]

@Ansub I am under the impression that 'Link' also does not perform a full page reload in v14 according to their docs

Either way, we should probably still rename the button something besides DiscordButton

I will close this PR though :)

[Ansub]

Link also does the same thing, if you see the link of the docs you shared, it says:

to provide prefetching and client-side navigation between routes

[epoll31]

Then should we use <Link prefetch={false}>? This way we are still using a link for SEO and general best practices?

[Ansub]

Then should we use <Link prefetch={false}>? This way we are still using a link for SEO and general best practices?

how will disabling prefetch a best practice, enlighten me please.

prefetching is done so that other page id already fetched to reduce load time when going to next page. making it false will disable the behaviour and then it will act just like an a tag.

[epoll31]

I thought that was what you were recommending.

I am confused as to what useRouter does better than Link in this case.

You mentioned that useRouter doesn't perform a full-page reload, but I think that Link also doesn't perform a full-page reload.

[Ansub]

I thought that was what you were recommending.

I am confused as to what useRouter does better than Link in this case.

You mentioned that useRouter doesn't perform a full-page reload, but I think that Link also doesn't perform a full-page reload.

yes both does the same thing

[epoll31]

So should we switch it to a Link? I can open a new PR that is directed to main since this branch is now closed.

[Ansub]

let's work on other stuff, this is not a deal breaker, both does the same work so it doesn't matter