search

Synthetica9 / nix-linter

Linter for the Nix expression language
BSD 3-Clause "New" or "Revised" License
158 stars 16 forks source link

Fix compatibility with hnix≥0.13.0 #51

Closed marsam closed 3 years ago

marsam commented 3 years ago

Raise upper bound on hnix.

hnix 0.13.0 replaced the Result type with Either[1].

[1] https://github.com/haskell-nix/hnix/commit/2fea0dc330bd3b3da10c893847b21ffb0855dca1

Synthetica9 commented 3 years ago

If it was replaced, then this is only compatible with hnix >0.13 right?

On Sat, 15 May 2021, 14:30 Mario Rodas, @.***> wrote:

Raise upper bound on hnix.

hnix 0.13.0 replaced the Result type with Either[1].

[1] @.*** https://github.com/haskell-nix/hnix/commit/2fea0dc330bd3b3da10c893847b21ffb0855dca1

You can view, comment on, or merge this pull request online at:

https://github.com/Synthetica9/nix-linter/pull/51 Commit Summary

  • Fix compatibility with hnix≥0.13.0

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Synthetica9/nix-linter/pull/51, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV7PJ3QONLGTJOPJ7XJHULTNZSP5ANCNFSM4453CDDQ .

marsam commented 3 years ago

then this is only compatible with hnix >0.13 right?

unfortunately yes, I'm not sure how to make it backwards compatible

Synthetica9 commented 3 years ago

I'm very sorry, this was mostly written as a proof of concept, and I am not super capable of maintaining it at the moment. I have invited you as a collaborator on this project, feel free to accept and merge this yourself if you want to.

expipiplus1 commented 3 years ago

merged in #53, thanks!