Fix all tests setup to use CL aggregators mocks and not the legacy oracle - Githubissues

Synthetixio / issues

0 stars 3 forks source link

Fix all tests setup to use CL aggregators mocks and not the legacy oracle #396

Closed artdgn closed 2 years ago

artdgn commented 2 years ago

Follow up from https://github.com/Synthetixio/synthetix/pull/1633

Almost all of our tests modify prices using the legacy oracle in exchange rates. This is highly problematic because:

This path is not used in actual deployments, and so the actual path used (CL aggregators) is undertested.
The gas measurements are incorrect pretty much always, which means that we have no idea what the actual gas impact or diff of any change.

Task:

[ ] Update all tests to use CL mock aggregators instead of the legacy .updateRates path.
[ ] Consider implementing https://sips.synthetix.io/sips/sip-81/ since it seems that this issue is the main effort for it.

artdgn commented 2 years ago

Done as SIP-193.