search

Synthetixio / issues

0 stars 3 forks source link

Subgraph issued debt for burnOnBehalf #427

Open 0xjocke opened 2 years ago

0xjocke commented 2 years ago

@dbeal-eth and @noahlitvin did some investigation. Current solution would be a SIP to improve the event so we can identify burn on behalf events. It's quite a lot of work so they are still exploring other solutions.

I suggested that we put a tooltip on "Issued Debt" explaining that burn on behalf cause some issues.

noahlitvin commented 2 years ago

👍 The event fix would also only correct the subgraph going forward, so we'd need to come up with a way to calculate the correct historical data off-chain and import.

I forget the specific context here, but maybe the tooltip is only necessary under certain conditions?

0xjocke commented 2 years ago

Screen Shot 2022-02-10 at 10 34 07 am The issue causes issued debt to display wrongly. If I burned in behalf of a wallet my wallet would show the issued debt. And the wallet which actually had the issued debt would show 0. The best would be to only show the tooltip on wallets that have burned on behalf of someone else and for wallets that had someone burn on behalf for them. But I'm not sure I can know that on the frontend. If the frontend can know that, the subgraphs should also be able to know that?

noahlitvin commented 2 years ago

Got it. Yeah, I don't think there's a way to distinguish that it's happened at all afaik.

cavalier-eth commented 2 years ago

needs v3