search

Synthetixio / js-monorepo

Standard JS conventions and utilities for working with Synthetix
33 stars 44 forks source link

SourceData.abi set as ContractInterface instead of ABI #158

Open koredefashokun opened 2 years ago

koredefashokun commented 2 years ago

In the declaration of the SourceData type here: https://github.com/Synthetixio/js-monorepo/blob/d8b882a83e3682aee13c9c40f2174aa030097193/packages/contracts-interface/src/synthetix.d.ts#L7

The abi field is set as a ethers.ContractInterface, but the code from the synthetix package actually returns a regular ABI.

fritzschoff commented 2 years ago

Hey, what do you mean by regular ABI? Just an array?