Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

MetaMask direct login isn't working on mobile browsers #19

Open drptbl opened 4 years ago

drptbl commented 4 years ago

Description: MetaMask direct login isn't working on mobile browsers.

Prerequisites: "MetaMask" app installed on mobile device and set up.

Reproduction steps:

  1. Go to Kwenta exchange page (https://kwenta-git-dev.synthetixio.vercel.app/exchange)
  2. Tap on "Connect Wallet" button
  3. Tap on "MetaMask" button

Actual result: User sees an information that MetaMask has to be installed first.

Expected result: Logging in through MetaMask works however you have to choose "WalletConnect" method and then "MetaMask". I suggest one of three options here:

  1. Add support for direct MetaMask login using MetaMask mobile app (if possible) => user should be redirected to "MetaMask" mobile app, asked if users wants to give access for exchange to his wallet, after accepted he should be logged in to the exchange.
  2. If above is not possible, maybe we could trigger "WalletConnect => MetaMask" flow (if possible) when user taps on "MetaMask" login method?
  3. If none of above applies, remove MetaMask method completely until MetaMask mobile app allows direct login on websites, but still it would be good to suggest that user can still login through MetaMask using "WalletConnect" somehow.

Environment: iPhone 11 Pro (Safari & Chrome) Samsung A30s (Chrome)

Screenshots / videos: RPReplay_Final1601062134

jwineman commented 4 years ago

This flow is controlled by https://github.com/blocknative/onboard. We can omit it from the walletModules on mobile probably. Approaches 1,2 probably requiring customizing onboard.

evgenyboxer commented 4 years ago

@drptbl can you recheck?

drptbl commented 4 years ago

@evgenyboxer nothing has changed here, still same behavior.