search

Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

fix: added check for window.ethereum #261

Closed jcmonte closed 3 years ago

jcmonte commented 3 years ago

Added a check for window.ethereum in getDefaultNetworkId() because "Connect Wallet" will not work until a provider is determined

image

Fixes #254

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/synthetixio/kwenta/E7Ax4eVMaTWH38Ege8bmNzy8Swvm
✅ Preview: https://kwenta-git-fix-connect-wallet-delay-synthetixio.vercel.app

cypress[bot] commented 3 years ago


Test summary

0 • 2 • 0 • 0

Run details
Project kwenta
Status Failed
Commit dfcc033464 ℹ️
Started Mar 2, 2021 10:01 PM
Ended Mar 2, 2021 10:03 PM
Duration 01:56 💡
OS Linux Ubuntu - 20.04
Browser Chrome 87

View run in Cypress Dashboard ➡️

Failures

trade-spec.js 1 Failed
1 Trades tests > Trade sUSD => sETH > should exchange with success
login-spec.js 1 Failed
1 Wallet tests > Connect metamask wallet > should login with success

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

evgenyboxer commented 3 years ago

nice catch! I wonder why are they not documenting this here - https://github.com/MetaMask/detect-provider 🤔