Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

feat: switch to dynamic icons with a fallback #272

Closed evgenyboxer closed 3 years ago

evgenyboxer commented 3 years ago

This PR allows for grabbing the synth icons dynamically using our https://github.com/Synthetixio/synthetix-assets repo.

It will fallback to a placeholder with the synth icon if it can't load the image (like, when we add a new synth, but still haven't produced an image for it).

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/synthetixio/kwenta/JBkBDExvghmqhjrhnntw5EhZut5Y
✅ Preview: https://kwenta-git-feat-dynamic-icons-synthetixio.vercel.app

cypress[bot] commented 3 years ago



Test summary

0 2 0 0


Run details

Project kwenta
Status Failed
Commit bfa0478c30 ℹ️
Started Mar 9, 2021 4:15 AM
Ended Mar 9, 2021 4:17 AM
Duration 01:54 💡
OS Linux Ubuntu - 20.04
Browser Chrome 87

View run in Cypress Dashboard ➡️


Failures

login-spec.js Failed
1 Wallet tests > Connect metamask wallet > should login with success
trade-spec.js Failed
1 Trades tests > Trade sUSD => sETH > should exchange with success

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard