Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

Slippage shown on Kwenta "Convert" page is different from what 1inch shows #328

Open drptbl opened 3 years ago

drptbl commented 3 years ago

Description: It seems that in some cases slippage is different on Kwenta comparing it to 1inch at the same time. I would expect them to be equal.

Prerequisites:

Reproduction steps:

  1. Go to Kwenta "Convert" page (https://dev.kwenta.io/dashboard/convert)
  2. Connect your wallet
  3. Select any synth (for example "sXAU") inside "From" drop-down
  4. Click on your synth balance to fill maximum amount to swap
  5. Notice shown slippage inside "Into" input field
  6. Head over to 1inch and use the same pair to see the slippage and compare it to what you've seen on Kwenta

Current behavior:

Expected behavior:

Screenshots: Below you can see that there was 1% difference in slippage between Kwenta and 1inch.

Screenshot_2021-04-09_at_00 14 33 Screenshot_2021-04-09_at_00 14 37

Desktop (please complete the following information):

evgenyboxer commented 3 years ago

I'm not sure where they are pulling their price from... but I'm using coingecko, and I guess it's OK to have some difference