Unreliable requests (synths and tokens) on "Convert" page

Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta

MIT License

11 stars 20 forks source link

Unreliable requests (synths and tokens) on "Convert" page #334

Open drptbl opened 3 years ago

drptbl commented 3 years ago

Description: There are two unreliable requests on "Convert" page:

"Convert" functionality doesn't work and "Select Token" modal is empty because of it. Other than fixing this, part of this task should also be to improve error handling in such case on Kwenta to avoid such things (slippage -100%):

It wasn't working for more than 1-2 hours when I was testing it.

Reproduction steps:

Go to Kwenta "Convert" page (https://dev.kwenta.io/dashboard/convert)

Desktop (please complete the following information):

OS: macOS Big Sur 11.2.2
Browser: Chrome 89.0.4389.95

evgenyboxer commented 3 years ago

Hmm... @justinjmoses @clementbalestrat @andytcf any ideas why these requests sometimes fail?

drptbl commented 3 years ago

synths.snx.eth.link request is also used on synthetix website now; "Synths" page: https://synthetix-website-git-feat-synths-page-synthetixio.vercel.app/synths so if this url fails to respond, not only convert feature won't be working but also "Synths" page.

jcmonte commented 3 years ago

I think this was a one time event with ipfs/ens domains. I'm not able to replicate this, but now we use zapper token lists which aren't ipfs/ens so I think this issue can be closed

synths.snx.eth.link also has a fallback with synthetix-assets for this case

jcmonte commented 3 years ago

Also improved the -100% slippage handling in #347