Closed jcmonte closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/synthetixio/kwenta/A2vUU9yDRjz6zDqji8EaNGoHxfas
✅ Preview: https://kwenta-git-feat-timer-til-open-synthetixio.vercel.app
Btw, I also noted that the countdown doesn't autohide once the opening time is reached.
On Mon, 17 May 2021, 16:23 Jeremy Chiaramonte, @.***> wrote:
@JChiaramonte7 commented on this pull request.
In utils/marketNextOpen.ts https://github.com/Synthetixio/kwenta/pull/369#discussion_r633525680:
+export const lseNextOpen = () => {
- moment.locale('gb', {
- workinghours: {
- 0: null,
- 1: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'],
- 2: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'],
- 3: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'],
- 4: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'],
- 5: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'],
- 6: null,
- },
- holidays: [
- // Recurring
- '*-01-01',
- // 2021
- '2021-04-02',
i'm not sure, but i know we do pause our synths for these holidays
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Synthetixio/kwenta/pull/369#discussion_r633525680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AON72DKMIT5JMZAMEKFMJLLTOEKFPANCNFSM443KVD5A .
Project | kwenta |
Status | Failed |
Commit | 07c1f2c198 ℹ️ |
Started | May 19, 2021 4:28 PM |
Ended | May 19, 2021 4:33 PM |
Duration | 04:19 💡 |
OS | Linux Ubuntu - 20.04 |
Browser | Chrome 89 ![]() |
View run in Cypress Dashboard ➡️
![]() |
login-spec.js ![]() |
1 ![]() |
|
---|---|---|---|
1 | Wallet tests > Connect metamask wallet > should login with success |
![]() |
|
![]() |
trade-spec.js ![]() |
1 ![]() |
|
1 | Trades tests > Trade sUSD => sETH > should exchange with success |
![]() |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Btw, I also noted that the countdown doesn't autohide once the opening time is reached. … On Mon, 17 May 2021, 16:23 Jeremy Chiaramonte, @.**> wrote: @JChiaramonte7 commented on this pull request. ------------------------------ In utils/marketNextOpen.ts <#369 (comment)>: > +export const lseNextOpen = () => { + moment.locale('gb', { + workinghours: { + 0: null, + 1: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'], + 2: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'], + 3: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'], + 4: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'], + 5: ['08:00:00', '12:00:00', '12:02:00', '16:30:00'], + 6: null, + }, + holidays: [ + // Recurring + '-01-01', + // 2021 + '2021-04-02', i'm not sure, but i know we do pause our synths for these holidays — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#369 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AON72DKMIT5JMZAMEKFMJLLTOEKFPANCNFSM443KVD5A .
Yeah @vbstreetz unfortunately sometimes the synth markets don't open exactly at the same time their tradfi counterparts do. So the synth is still frozen in our system. I'm guessing there is a delay with our keeper