Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

feat: candlestick charts #381

Closed jcmonte closed 3 years ago

jcmonte commented 3 years ago

Candlesticks

Resolves https://github.com/Synthetixio/issues/issues/157

image

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/synthetixio/kwenta/ENVagdsvbCQbuPaWx9soRPSrJsUE
✅ Preview: https://kwenta-git-feat-candlesticks-synthetixio.vercel.app

cypress[bot] commented 3 years ago



Test summary

1 1 0 0Flakiness 0


Run details

Project kwenta
Status Failed
Commit 69a7b18cb3 ℹ️
Started Jun 7, 2021 11:06 PM
Ended Jun 7, 2021 11:09 PM
Duration 03:01 💡
OS Linux Ubuntu - 20.04
Browser Chrome 89

View run in Cypress Dashboard ➡️


Failures

tests/e2e/specs/trade-spec.js Failed
1 Trades tests > Trade sUSD => sETH > should exchange with success

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

kelonye commented 3 years ago

Confirming if the chart type is not supposed to be synced?

Screenshot 2021-06-08 at 20 55 02
jcmonte commented 3 years ago

Confirming if the chart type is not supposed to be synced?

Screenshot 2021-06-08 at 20 55 02

Yeah the chart type toggle is off centered for now because in the figma designs we forgot to include the y-axis. Didn't want it cover up the y-axis on kwenta