Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

Unable to build project after installing npm dependencies without package-lock.json present #384

Closed drptbl closed 3 years ago

drptbl commented 3 years ago

Description: I'm unable to update repository to node 14 and npm 7 because if you remove package-lock.json before installing npm dependencies - you're not able to build the project.

This issue occurs on any node/npm version.

Reproduction steps:

  1. git clone https://github.com/Synthetixio/kwenta
  2. cd kwenta
  3. rm package-lock.json
  4. npm install
  5. npm run build

Screenshots:

Screenshot_2021-05-28_at_01 22 38

Desktop (please complete the following information):

kelonye commented 3 years ago

I suspect it's a type confict between:

Screenshot 2021-06-04 at 17 55 59

Possibly a breaking change from 5.0.x to 5.1.x+. I've pushed a fix here to bump the ethers version in monorepo packages to 5.3.+