Closed dbeal-eth closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/synthetixio/kwenta/2qo1i2p9iDwH7VMWzrS5N9LLKkoJ
✅ Preview: https://kwenta-git-impl-synthetix-queries-synthetixio.vercel.app
@JChiaramonte7 fixed the CI, testing environment deployed
for some reason the website is functioning much slower than in local dev environment. I think I have an idea what the problem is, but for now you should be able to test the functionality.
@KillerByte Thank you sir. I'll take a look again today.
communicated with @clementbalestrat and determined we should merge this into dev so that other feature branches can start using it.
this PR implements 3 major refactoring steps:
@synthetixio/wei
@synthetixio/queries
CurrencyKey
to be limited set of strings, which exposes case where we attempt to pass a CurrencyKey that is not actually a synth (surprisingly common bug that requires discussion)Please read these notes before reviewing:
currencyKey as CurrencyKey
added is actually an existing bug in Kwenta where we are passing a non-synth to something that should only work with Synths (ex. a query which connect to the Synthetix subgraph or Synthetix contract). This is of course not good behavior so I left it in for right now and later we can make fine-grained fixes as we go.CurrencyKey
is currently statically defined in thecontracts-interface
, but in the future we would like for this value to be derived dynamically fromsynthetix
. This is in progress and should be impl soon.useSynthetixQueries
pattern is designed to maximize code reusability for many networks and providers.What has already been tested:
What needs to be tested:
/hours 15 july