Synthetixio / kwenta

DEPRECATED. Please use: https://github.com/Kwenta/kwenta
MIT License
11 stars 20 forks source link

feat: fee reclamation improvements #446

Closed kelonye closed 3 years ago

kelonye commented 3 years ago
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/synthetixio/kwenta/CgFgVMfS6m17F4cykRnTRxRh9MVD
✅ Preview: https://kwenta-git-feat-fee-reclaim-synthetixio.vercel.app

kelonye commented 3 years ago

Hey @JChiaramonte7! I've implemented the switch to wei fixes.

kelonye commented 3 years ago

Gotcha. I think every query should probably have an accompanying hook to handle request errors etc... Will resume this after finishing some task on stats.

On Mon, Aug 2, 2021 at 8:14 PM Dave @.***> wrote:

@.**** commented on this pull request.

In hooks/trades/useTxReclaimFee.ts https://github.com/Synthetixio/kwenta/pull/446#discussion_r681139758:

@@ -0,0 +1,16 @@ +import { useMemo } from 'react'; +import Wei, { wei } from @.***/wei'; + +import { useTxReclaimFee as useTxReclaimFeeQuery } from 'queries/trades/useTxReclaimFee'; +import { zeroBN } from 'utils/formatters/number'; + +const useTxReclaimFee = (timestamp: number): Wei => {

and this also doesn't need its own file

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Synthetixio/kwenta/pull/446#pullrequestreview-720426216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AON72DJEZNROLK5H7N7EZNTT23G65ANCNFSM5AQCEZSA .

kelonye commented 3 years ago

@dvd-schwrtz I've moved the queries to js-monorepo.

kmeraz commented 3 years ago

linking here for visibility:

https://github.com/Synthetixio/issues/issues/223