Feature/add-to-metamask-button

Synthetixio / synthetix-exchange

The Synthetix Exchange dApp code

https://synthetix.exchange

121 stars 92 forks source link

Feature/add-to-metamask-button #499

Closed andytcf closed 4 years ago

andytcf commented 4 years ago

In this PR:

Add an "add-to-metamask" button in the synth overview with metamask add token functionality
Remove hyphens in SWAP-VIA-1INCH

LOOM VIDEO FOR QA:

https://www.loom.com/share/f8b4142c61f1434caf2a8c58389c8f25

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/synthetixio/synthetix-exchange/rfdg2vgfn
✅ Preview: https://synthetix-excha-git-fork-andytcf-feature-add-to-metamask-0c2401.synthetixio.vercel.app

evgenyboxer commented 4 years ago

@AndyTCF great work, thanks for the video.

The two main things left for the PR are:

Please use snxJSConnector to grab the right contract.
Since no packages were really added, I think we just drop the package-lock.json changes... maybe its an issue with the node version you are running, but generally speaking we are very cautious when it comes to updating the lock file without any changes to the packages.

0xclem commented 4 years ago

Looks great @AndyTCF. Looking forward to merging it once you're done with the few changes Ev mentioned.