Signer fix - Githubissues

Synthetixio / synthetix-js

[deprecated] Please use https://github.com/Synthetixio/js-monorepo/tree/master/packages/contracts-interface

63 stars 44 forks source link

Signer fix #18

Closed 0xclem closed 5 years ago

jjgonecrypto commented 5 years ago

@clementbalestrat I added a few things:

Much better test coverage for existing contracts (mostly the auto-generated contracts with ABIs and addresses), but also tests deployed contracts on all networks (a kind of integration test).
Removed redundant libraries from package.json
Upgraded @ledger libraires (better transpiling support)

Note: I wasn't able to test the hardware signers without an actual device. We could just stub them but not sure there's a ton of value.