codecov[bot]
commented
11 months ago Codecov Report
Merging #2160 (bb6a240) into develop (5860850) will not change coverage. Report is 1 commits behind head on develop. The diff coverage is
100.00%.
@@ Coverage Diff @@
## develop #2160 +/- ##
========================================
Coverage 92.48% 92.48%
========================================
Files 91 91
Lines 2276 2276
Branches 673 673
========================================
Hits 2105 2105
Misses 171 171 | Files | Coverage Δ | |
|---|---|---|
| contracts/RewardsDistribution.sol | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
in the simplest possible way, fix a bug which prevents reward distribution from getting sent to L2 due to internal OOG gas logic in optimism contract (normally if you are OOG then the remaining code in RewardsDistribution would also fail, but optimism deliberately consumes an excessive amount of gas in a way that causes only the internal call to fail)
in accordance with SIP-2036
note: if you are wondering why I didnt just call the rewards distribution receiver contract normally and continue to be using hte low level call, the reason is im trying to keep changes to a minimal and this change basically ended up being a 1 line changes.