Bug in apostrophe encoding

Synthoid / ExportSheetData

Add-on for Google Sheets that allows sheets to be exported as JSON or XML.

MIT License

236 stars 46 forks source link

Bug in apostrophe encoding #77

Closed basalicante closed 5 years ago

basalicante commented 5 years ago

First of all, thank for your great work. I'm using it all the time!

Found a bug in the export of apostrophes to xml, they get encoded as &apos; rather than '

Attaching an image as an example.

Thanks!

jeelii commented 5 years ago

Also "&" gets encoded as &amp; instead of &

Thank you so much for the plugin!

Synthoid commented 5 years ago

Just pushed v52 which should fix this issue. The problem was that the new backend for exporting XML always encodes characters, causing them to be double encoded.

Unfortunately, this means the "Don't format illegal characters" option is no longer functional and has been removed. Apostrophes are no longer encoded either because this. Fortunately, apostrophe encoding is only needed when values are wrapped with single quotes, which is impossible here.