SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
564 stars 93 forks source link

Kit view items can't be triggered simultaneously #126

Closed sichtbeton closed 1 year ago

sichtbeton commented 1 year ago

Steps to reproduce:

Expected behavior would be to hear a second sound. But it just stays silent.

It would be preferable to hear the second trigger too, making finger drumming much easier and accessible.

m-m-adams commented 1 year ago

I looked at this when I was integrating the mode but one sounding note per row is pretty fundamental to the deluge sound engine - consider what the sequencer would look like if you had two overlapping notes. It would be possible to have a second note cut off the first which might be more intuitive for percussive sounds

weavermedia commented 1 year ago

I always wondered why kit sounds had the POLY and LEGA options in the VOICE menu when they don't actually do anything. Or do they?

For the kit view my preference would be for the second note to cut off the first note rather than not hear the second note.

sichtbeton commented 1 year ago

I always wondered why kit sounds had the POLY and LEGA options in the VOICE menu when they don't actually do anything. Or do they?

For the kit view my preference would be for the second note to cut off the first note rather than not hear the second note.

Actually, this is a very cool idea. This way you can play very rhythmical with longer samples.

weavermedia commented 1 year ago

Any reason why this is not planned?

sichtbeton commented 1 year ago

I guess nobody was interested in this. Can leave it open of course.

sapphire-arches commented 1 year ago

In general leaving the issue open is preferred, as it helps track what people are interested in and a venue for collecting technical discussion related to implementation or bug fixing.

On Tue, Jul 4, 2023, 14:16 sichtbeton @.***> wrote:

I guess nobody was interested in this. Can leave it open of course.

— Reply to this email directly, view it on GitHub https://github.com/SynthstromAudible/DelugeFirmware/issues/126#issuecomment-1620753454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALRZ7AGXQSURUKIHCBVLS3XOSB2ZANCNFSM6AAAAAAZ2LFBQI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

m-m-adams commented 1 year ago

Agreed - while this is currently 'intended behaviour' I do think the discussion around how duplicate notes are handled is worthwhile and I'd love to see a creative solution for it

The same issue also applies in normal synths, if you hold a note and then press the same note elsewhere on the keyboard nothing happens

sichtbeton commented 1 year ago

So should I close this issue then as it seems to be intended?

m-m-adams commented 1 year ago

Moving to discussion for now - I think an option to cut off existing notes when a new note on is received is reasonable if someone wants to implement it