Default phase retrigger causes clicks when triggering note in FM Mode

[requiets]

Please describe the problem:

Triggering notes in audition or iso keyboard creates a pop/clipping/click noise at the beginning of the sample. This is most noticeable when playing medium or harder velocity and is not heard when lightly pressing or playing with playing with portamento. Prevalent in FM synth mode but have also experienced in other modes, though not often.

What is the expected behavior?

Note triggers pitch without additional pop/click noise.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Nightly

What is the firmware name:

deluge-v1_2_0-nightly+2024_05_16-f636f84

If possible provide the steps to reproduce the issue and upload additional media:

Selected FM Synth Mode, press pad in either ISO keyboard or audition with medium or higher velocity.

[seangoodvibes]

DX7 FM synth or original FM synth?

[requiets]

FM Synth. My mistake - I thought that was the same as DX7 FM.

On Thu, May 16, 2024 at 6:44 PM Sean Ditny @.***> wrote:

DX7 FM synth or original FM synth?

— Reply to this email directly, view it on GitHub https://github.com/SynthstromAudible/DelugeFirmware/issues/1946#issuecomment-2116478643, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIRG2KSLSB5Y4XJ3U2D6T73ZCVOIHAVCNFSM6AAAAABH2TCZ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGQ3TQNRUGM . You are receiving this because you authored the thread.Message ID: @.***>

[sapphire-arches]

Is this different compared to prior firmware versions? if not, there's a few common causes:

• attack set to zero
• sample start not aligned to a zero crossing

[m-m-adams]

Yeah, the fix is to set phase retrigger to 0 on the carriers. It's 5th pad from the bottom in the oscillator column

We should probably do that by default in FM synths instead of having it off

[m-m-adams]

Closing - clicks are already avoidable and they can be useful for sound design