search

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
567 stars 96 forks source link

Mod knob mappings should not be overwritten when Oscillator-Type is already wavetable #2042

Open bnhrsch opened 4 months ago

bnhrsch commented 4 months ago

Please describe the problem:

The mappings of the Gold-Encoders (Custom 2-3) get overwritten every time you select a new wavetable. If you already have a Wavetable-OSC you should be able to map other values to the encoders without them being overwritten when you select a new Wavetable.

What is the expected behavior?

No change in mapping when OSC-Type is already wavetable

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

other

What is the firmware name:

Release 1.1 RC 1

If possible provide the steps to reproduce the issue and upload additional media:

Custom 2 and 3 are now overwritten to be OSC-1 Pos + OSC-1->LFO-2

sapphire-arches commented 4 months ago

the code that does this overwriting is here: https://github.com/SynthstromAudible/DelugeFirmware/blob/c313ea32c9ab5fff68ca7b7c79618c6d85009021/src/deluge/gui/ui/browser/sample_browser.cpp#L848-L861

we'd want to not run that logic if the oscillator is already a wavetable.