SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
552 stars 89 forks source link

Refactoring: Update sequence/mpe/automation clear/shift/nudge code and documentation #2108

Closed seangoodvibes closed 1 month ago

seangoodvibes commented 1 month ago

Updated implementation of the automation defaults which dictate the behaviour of clearing / shifting / nudging sequences on automation parameters and notes/sample and MPE

The refactoring in this PR extends the previous refactoring done for clearing a clip by passing "clear/shift/nudgeAutomation" and "clearSequenceAndMPE" as variables to the various clear/shift/nudge functions as opposed to checking in those functions for the automation defaults or whether you're in automation view, etc.

Also refactored the code for shifting audio clip automation into MPE and non-MPE automation.

Update documentation as well where appropriate.

github-actions[bot] commented 1 month ago

Test Results

44 tests  +1   44 :white_check_mark: +1   0s :stopwatch: ±0s  8 suites ±0    0 :zzz: ±0   8 files   ±0    0 :x: ±0 

Results for commit 0e97848d. ± Comparison against base commit a8cbf007.

:recycle: This comment has been updated with latest results.